Re: Rename some rel truncation related constants at the top of vacuumlazy.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rename some rel truncation related constants at the top of vacuumlazy.c
Date: 2022-07-19 03:55:55
Message-ID: 914775.1658202955@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> I propose to rename some of the rel truncation related constants at
> the top of vacuumlazy.c, per the attached patch. The patch
> consolidates related constants into a single block/grouping, and
> imposes a uniform naming scheme.

Um ... you seem to have removed some useful comments?

Personally I wouldn't do this, as I don't think the renaming
brings much benefit, and it will create a hazard for back-patching
any fixes that might be needed in that code. I'm not hugely upset
about it, but that's the way I'd vote if asked.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-07-19 04:07:59 Re: Rename some rel truncation related constants at the top of vacuumlazy.c
Previous Message Peter Geoghegan 2022-07-19 03:47:49 Rename some rel truncation related constants at the top of vacuumlazy.c