Re: pgsql: Harmonize reorderbuffer parameter names.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
Date: 2022-09-18 05:00:57
Message-ID: CAH2-Wz=1Bzwq5Cc-vLa_x-hoA6K+jGd9NmmmSmW9ELp57-cfvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Sep 17, 2022 at 9:47 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
> short some parameter names.

I actually noticed that clang-tidy missed this one myself, shortly
after commit. I still haven't figured out why, but it seems like it
might be a bug in the readability-named-parameter check. Could also
have something to do with my clang tooling config, even though it
works well overall.

I'll fix this soon, in any case.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-09-18 06:41:59 pgsql: Remove unused argument "isSlice" from transformAssignmentSubscri
Previous Message Tom Lane 2022-09-18 04:47:39 Re: pgsql: Harmonize reorderbuffer parameter names.