| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Harmonize reorderbuffer parameter names. |
| Date: | 2022-09-18 04:47:39 |
| Message-ID: | 92291.1663476459@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> Harmonize reorderbuffer parameter names.
I'm confused about this, because it didn't fix the (ahem) poster-child
case?
-extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
-extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
+extern void ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid,
+ TransactionId subxid, XLogRecPtr lsn);
+extern void ReorderBufferCommitChild(ReorderBuffer *rb, TransactionId, TransactionId,
XLogRecPtr commit_lsn, XLogRecPtr end_lsn);
ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
short some parameter names.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-09-18 05:00:57 | Re: pgsql: Harmonize reorderbuffer parameter names. |
| Previous Message | Peter Geoghegan | 2022-09-18 00:21:23 | pgsql: Harmonize reorderbuffer parameter names. |