| From: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "create publication..all tables" ignore 'partition not supported' error |
| Date: | 2017-05-31 06:17:02 |
| Message-ID: | CAGz5QCK30cVqZNBk1fUCVuXzcTsaiVy4VMniYXKmZs8DwJEUVQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 31, 2017 at 12:58 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I'd say we can fix this issue by just changing the query. Attached
> patch changes the query so that it can handle publication name
> correctly, the query gets complex, though.
>
In is_publishable_class function, there are four conditions to decide
whether this is a publishable class or not.
1. relkind == RELKIND_RELATION
2. IsCatalogClass()
3. relpersistence == 'p'
4. relid >= FirstNormalObjectId /* Skip tables created during initdb */
I think the modified query should have a check for the fourth condition as well.
Added to open items.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2017-05-31 06:35:07 | Re: Effect of changing the value for PARALLEL_TUPLE_QUEUE_SIZE |
| Previous Message | Tom Lane | 2017-05-31 05:57:09 | Re: [PATCH] quiet conversion warning in DatumGetFloat4 |