| From: | Claudio Freire <klaussfreire(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| Date: | 2016-09-06 17:20:08 |
| Message-ID: | CAGTBQpaFaQb5gaoVvU+3GGu7zx0XCJy0C9GrhA10SB8sbKJRCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 6, 2016 at 2:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The not-quoting-if-not-needed doesn't appear to do anything useful for me:
>> 'pg-install/bin/pg_ctl' -D 'pg-install/var/data' -l logfile start
>
> Dash is considered a character that needs quoting. It might be possible
> to avoid that if we could be certain that appendShellString's output would
> never be placed in a spot where it could be taken for a switch, but that
> seems like a large assumption to me. Or maybe we could treat it as
> forcing quotes only if it starts the string; but I don't personally care
> enough to write the code for that. Feel free if you want to.
Wouldn't it be taken for a switch even with quoting?
Quoting "-D" seems to work fine, which would suggest the above is true.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-09-06 17:23:11 | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| Previous Message | Tom Lane | 2016-09-06 17:08:51 | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-09-06 17:23:11 | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
| Previous Message | Alvaro Herrera | 2016-09-06 17:12:58 | Re: SELECT FOR UPDATE regression in 9.5 |