Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl
Date: 2016-09-06 17:23:11
Message-ID: 20160906172311.ngvezt24jak4tlgb@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2016-09-06 13:08:51 -0400, Tom Lane wrote:
> Dash is considered a character that needs quoting. It might be possible
> to avoid that if we could be certain that appendShellString's output would
> never be placed in a spot where it could be taken for a switch, but that
> seems like a large assumption to me. Or maybe we could treat it as
> forcing quotes only if it starts the string; but I don't personally care
> enough to write the code for that. Feel free if you want to.

But quotes are interpreted by the shell, not by the called program. So I
don't think putting --whatnot in quotes changes anything here?

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-09-06 17:26:50 pgsql: Repair whitespace in initdb message.
Previous Message Claudio Freire 2016-09-06 17:20:08 Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-09-06 17:32:07 Re: Forbid use of LF and CR characters in database and role names
Previous Message Claudio Freire 2016-09-06 17:20:08 Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl