| From: | Claudio Freire <klaussfreire(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Szymon Guz <mabewlun(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal |
| Date: | 2013-07-07 22:16:52 |
| Message-ID: | CAGTBQpY-QP2zZzb4Nn1owdhY7dKDCXX9tpHSv1yfBqg11GBDsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Jul 7, 2013 at 4:28 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote:
>> You really want to test more than just the str. The patch contains
>> casts to int and float, which is something existing PLPython code will
>> be doing, so it's good to test it still can be done with decimal.
>
> Let's remember that we are regression testing PL/Python here, not
> Python. The functionality of PL/Python is to convert a numeric to
> Decimal, and that's what we are testing. What Python can or cannot do
> with that is not our job to test.
I was just proposing to test behavior likely to be expected by
PL/Python functions, but you probably know better than I.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-07-08 02:37:55 | pgsql: Fix planning of parameterized appendrel paths with expensive joi |
| Previous Message | Peter Eisentraut | 2013-07-07 20:23:26 | pgsql: pg_isready: Make --help output more consistent with other utilit |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2013-07-08 00:15:00 | Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc |
| Previous Message | Markus Wanner | 2013-07-07 21:48:51 | Re: Review: extension template |