| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Claudio Freire <klaussfreire(at)gmail(dot)com> |
| Cc: | Szymon Guz <mabewlun(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal |
| Date: | 2013-07-07 19:28:52 |
| Message-ID: | 1373225332.12837.22.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote:
> You really want to test more than just the str. The patch contains
> casts to int and float, which is something existing PLPython code will
> be doing, so it's good to test it still can be done with decimal.
Let's remember that we are regression testing PL/Python here, not
Python. The functionality of PL/Python is to convert a numeric to
Decimal, and that's what we are testing. What Python can or cannot do
with that is not our job to test.
> Existing python code will also expect the number to be a float, and
> will try to operate against other floats. That's not going to work
> anymore, that has to go into release notes.
Right, this will be listed in the release notes under upgrade caveats.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-07-07 19:35:13 | Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal |
| Previous Message | Magnus Hagander | 2013-07-07 11:40:25 | pgsql: Fix include-guard |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-07-07 19:35:13 | Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal |
| Previous Message | Peter Eisentraut | 2013-07-07 19:19:10 | Re: [PATCH] Add transforms feature |