| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document |
| Date: | 2023-11-16 23:25:33 |
| Message-ID: | CAGRkXqRs+szVwOjSKF71QGnZDQ62-Z=RqbHqT6QTR1o=ueLjVg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jian,
Thanks for your comments, a new version is attached.
Thanks,
Shihao
On Fri, Nov 10, 2023 at 9:59 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> On Wed, Nov 1, 2023 at 10:30 AM shihao zhong <zhong950419(at)gmail(dot)com>
> wrote:
> >
> > Thank you for your feedback on my previous patch. I have fixed the issue
> and attached a new patch for your review. Could you please take a look for
> it if you have a sec? Thanks
> >
>
> Your patch works fine. you can see it here:
> https://cirrus-ci.com/task/6481922939944960
> in an ideal world, since the doc is already built, we can probably
> view it as a plain html file just click the ci test result.
>
> in src/sgml/ref/create_table.sgml:
> "Each exclude_element can optionally specify an operator class and/or
> ordering options; these are described fully under CREATE INDEX."
>
> You may need to update this sentence to reflect that exclude_element
> can also optionally specify collation.
>
| Attachment | Content-Type | Size |
|---|---|---|
| update_document_exclude_with_collate_v3.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-11-17 00:43:43 | Re: lazy_scan_heap() should release lock on buffer before vacuuming FSM |
| Previous Message | Tom Lane | 2023-11-16 23:06:30 | Re: Hide exposed impl detail of wchar.c |