From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | Shruti B Iyer <siyer(at)pivotal(dot)io>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>, Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io> |
Subject: | Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience |
Date: | 2017-06-07 20:47:00 |
Message-ID: | CAGRPzo_25RwoTxLMVpGy1SANNkD4KaCw0YwdWWBJmV1K-dorbQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello,
Here is a new set of patches with the bug fixed. Good catch, Surinder!
Thanks,
Joao & Sarah
On Tue, Jun 6, 2017 at 12:24 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer <siyer(at)pivotal(dot)io> wrote:
>
>> Hi Surinder,
>>
>> On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt <reckhardt(at)pivotal(dot)io>
>> wrote:
>>
>>> On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar <
>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Matthew,
>>>>
>>>> Couple of review comments:
>>>> 1) Clicking on a new added row(after save) results in console error -
>>>> screenshot attached.
>>>>
>>>
>>>
>> We tried to follow the steps you provided to replicate the bug but
>> couldn't replicate the error. Can you provide further instructions to help
>> us replicate the bug? Perhaps share a screen video if that makes sense.
>> Is this occurring on the Edit Table view?
>>
> Sorry for wrong steps.
> No need to add a new row, just double clicking on row selection column
> of last row will throw that error.
>
>>
>> Thanks,
>> Shruti and Matt
>>
>
>
Attachment | Content-Type | Size |
---|---|---|
1-update-slickgrid.diff | text/plain | 305.1 KB |
2-improve-selecting-cells.diff | text/plain | 86.8 KB |
3-drag-and-select.diff | text/plain | 16.6 KB |
4-remove-checkboxes.diff | text/plain | 42.9 KB |
5-introduces-xcellselectionmodel.diff | text/plain | 88.1 KB |
6-drag-and-drop-selection-alignment.diff | text/plain | 9.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | George Gelashvili | 2017-06-07 21:21:10 | Re: [pgAdmin4] [PATCH] History Tab rewrite in React |
Previous Message | Joao Pedro De Almeida Pereira | 2017-06-07 18:10:04 | Re: [pgAdmin4][Patch]: Load module's JS files only when required |