Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi!

Thanks, patch applied... but I have one issue and one question:

- There are changes to SlickGrid, the addition of a function to scroll
a column into view. Is this submitted upstream and accepted?

- One of the regression tests now fails because it's trying to access
an element that's out of the clickable area. If I widen then browser
for testing it passes so I believe it's just the test that needs
fixing. Can you take a look at that ASAP please?

ERROR: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View data with given test data
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 100, in runTest
self._add_row()
File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 255, in _add_row
self._update_cell(cell_xpath, config_data[str(idx)])
File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 182, in _update_cell
save_btn_xpath
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 77, in click
self._execute(Command.CLICK_ELEMENT)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 491, in _execute
return self._parent.execute(command, params)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 238, in execute
self.error_handler.check_response(response)
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 193, in check_response
raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element is not clickable
at point (726, 397)
(Session info: chrome=58.0.3029.110)
(Driver info: chromedriver=2.29.461585
(0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3
x86_64)

Thanks - this is a very nice improvement!

On Wed, Jun 7, 2017 at 9:47 PM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:
> Hello,
>
> Here is a new set of patches with the bug fixed. Good catch, Surinder!
>
> Thanks,
> Joao & Sarah
>
>
>
> On Tue, Jun 6, 2017 at 12:24 AM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>> Hi
>>
>> On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer <siyer(at)pivotal(dot)io> wrote:
>>>
>>> Hi Surinder,
>>>
>>> On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt <reckhardt(at)pivotal(dot)io>
>>> wrote:
>>>>
>>>> On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar
>>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>> Hi Matthew,
>>>>>
>>>>> Couple of review comments:
>>>>> 1) Clicking on a new added row(after save) results in console error -
>>>>> screenshot attached.
>>>>
>>>>
>>>
>>> We tried to follow the steps you provided to replicate the bug but
>>> couldn't replicate the error. Can you provide further instructions to help
>>> us replicate the bug? Perhaps share a screen video if that makes sense.
>>> Is this occurring on the Edit Table view?
>>
>> Sorry for wrong steps.
>> No need to add a new row, just double clicking on row selection column of
>> last row will throw that error.
>>>
>>>
>>> Thanks,
>>> Shruti and Matt
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company