Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)

On Sat, Jun 25, 2016 at 6:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>
> If that is the explanation, I'm suspicious that it's got something to do
> with the interaction of a static inline-able (single-call-site) function
> and taking the address of a formal parameter. We certainly have multiple
> other instances of each thing, but maybe not both at the same place.
> This leads to a couple of suggestions for dodging the problem:
>
> 2. Don't pass the original formal parameter to
> get_foreign_key_join_selectivity, ie do something like
>
> static double
> calc_joinrel_size_estimate(PlannerInfo *root,
> RelOptInfo *outer_rel,
> RelOptInfo *inner_rel,
> double outer_rows,
> double inner_rows,
> SpecialJoinInfo *sjinfo,
> - List *restrictlist)
> + List *orig_restrictlist)
> {
> JoinType jointype = sjinfo->jointype;
> + List *restrictlist = orig_restrictlist;
> Selectivity fkselec;
> Selectivity jselec;
> Selectivity pselec;
>
>
The problem appears to be related to 'taking the address of a formal
parameter'. NOT passing the original formal parameter to
get_foreign_key_join_selectivity fixes it (dodges the problem) on VS2013.
Resulting binaries seem to work fine as initdb doesn't experience child
process crash anymore. 'vcregress check' does not report any failures also.

Anyways, We have decided to use VS2015 tool chain for 9.6beta2 release.

Thanks everyone for the valuable input and help. Appreciate it!

Regards,
Haroon

--
Haroon http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services