Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)

"Haroon ." <contact(dot)mharoon(at)gmail(dot)com> writes:
> On Sat, Jun 25, 2016 at 6:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This leads to a couple of suggestions for dodging the problem:
>>
>> 2. Don't pass the original formal parameter to
>> get_foreign_key_join_selectivity, ie do something like
>>
>> static double
>> calc_joinrel_size_estimate(PlannerInfo *root,
>> RelOptInfo *outer_rel,
>> RelOptInfo *inner_rel,
>> double outer_rows,
>> double inner_rows,
>> SpecialJoinInfo *sjinfo,
>> - List *restrictlist)
>> + List *orig_restrictlist)
>> {
>> JoinType jointype = sjinfo->jointype;
>> + List *restrictlist = orig_restrictlist;
>> Selectivity fkselec;
>> Selectivity jselec;
>> Selectivity pselec;
>>
>>
> The problem appears to be related to 'taking the address of a formal
> parameter'. NOT passing the original formal parameter to
> get_foreign_key_join_selectivity fixes it (dodges the problem) on VS2013.

Thanks for investigating! I'll go commit that change. I wish someone
would put up a buildfarm critter using VS2013, though.

regards, tom lane