Re: [parallel query] random server crash while running tpc-h query on power2

On Mon, Aug 15, 2016 at 6:02 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Sat, Aug 13, 2016 at 4:36 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> > AFAICS, your patch seems to be the right fix for this issue, unless we
> > need the instrumentation information during execution (other than for
> > explain) for some purpose.
>
> Hmm, I disagree. It should be the job of
> ExecParallelRetrieveInstrumentation to allocate its data in the
> correct context, not the responsibility of nodeGather.c to work around
> the fact that it doesn't. The worker instrumentation should be
> allocated in the same context as the regular instrumentation
> information, which I assume is probably the per-query context.
>

I agree, this make sense.

Here is the patch to allocate worker instrumentation into same context
as the regular instrumentation which is per-query context.

PFA patch.

--
Rushabh Lathia
www.EnterpriseDB.com