| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [parallel query] random server crash while running tpc-h query on power2 |
| Date: | 2016-08-15 12:32:48 |
| Message-ID: | CA+Tgmob9dabioB=nK=0p38ynar1byshimYjmzoLVrboc0+Wt=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 13, 2016 at 4:36 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> AFAICS, your patch seems to be the right fix for this issue, unless we
> need the instrumentation information during execution (other than for
> explain) for some purpose.
Hmm, I disagree. It should be the job of
ExecParallelRetrieveInstrumentation to allocate its data in the
correct context, not the responsibility of nodeGather.c to work around
the fact that it doesn't. The worker instrumentation should be
allocated in the same context as the regular instrumentation
information, which I assume is probably the per-query context.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shay Rojansky | 2016-08-15 12:33:33 | Re: Slowness of extended protocol |
| Previous Message | Aleksander Alekseev | 2016-08-15 12:21:21 | Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables) |