From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | Marko Tiikkaja <marko(at)joh(dot)to> |
Cc: | PosTGrESql hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Display oprcode and its volatility in \do+ |
Date: | 2014-01-16 08:53:25 |
Message-ID: | CAGPqQf0152872U0hrDhdfG4XkES4dWx70WqBZbJtJEshsc4UTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I have reviewed you patch.
-- Patch got applied cleanly (using patch -p1)
-- Make & Make install works fine
-- make check looks good
I done code-walk and it looks good. Also did some manual testing and haven't
found any issue with the implementation.
Even I personally felt the Function and Volatility is nice to have info
into \do+.
Marking it as ready for committer.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
On Fri, Jan 10, 2014 at 7:12 AM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> Hi,
>
> Here's a patch for $SUBJECT, displaying information which I find quite
> tedious to locate using alternative methods. Hopefully someone else does,
> too. Or doesn't. Not sure.
>
>
> Regards,
> Marko Tiikkaja
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
--
Rushabh Lathia
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Harris | 2014-01-16 10:20:51 | Re: PoC: Partial sort |
Previous Message | Heikki Linnakangas | 2014-01-16 08:35:11 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |