Re: Display oprcode and its volatility in \do+

From: Marko Tiikkaja <marko(at)joh(dot)to>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: PosTGrESql hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Display oprcode and its volatility in \do+
Date: 2014-01-16 10:49:44
Message-ID: 52D7B948.4060103@joh.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/16/14 9:53 AM, Rushabh Lathia wrote:
> I have reviewed you patch.
>
> -- Patch got applied cleanly (using patch -p1)
> -- Make & Make install works fine
> -- make check looks good
>
> I done code-walk and it looks good. Also did some manual testing and haven't
> found any issue with the implementation.
>
> Even I personally felt the Function and Volatility is nice to have info
> into \do+.
>
> Marking it as ready for committer.

Thanks for reviewing!

Regards,
Marko Tiikkaja

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2014-01-16 11:02:19 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Peter Geoghegan 2014-01-16 10:26:38 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE