| From: | Jelte Fennema <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jacob Champion <jchampion(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |
| Date: | 2023-04-21 08:20:35 |
| Message-ID: | CAGECzQSwGkcN51gDGyx1ZTuzoy+pc3G7P+H-6Bge+oH1fP1Zhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Okay, I rebased again. Indeed 983ec23007b gave the most problems.
On Fri, 7 Apr 2023 at 10:02, Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> wrote:
>
> The patch set does not apply any more.
>
> I tried to rebase locally; even leaving out 1 ("libpq: Run pgindent
> after a9e9a9f32b3"), patch 4 ("Start using new libpq cancel APIs") is
> harder to resolve following 983ec23007b (I suppose).
>
> Appart from that, the implementation in v19 sounds good to me, and seems
> worthwhile. FWIW, as said before, I also implemented it in Psycopg in a
> sort of an end-to-end validation.
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0003-Add-non-blocking-version-of-PQcancel.patch | application/octet-stream | 44.1 KB |
| v20-0004-Start-using-new-libpq-cancel-APIs.patch | application/octet-stream | 10.2 KB |
| v20-0002-Return-2-from-pqReadData-on-EOF.patch | application/octet-stream | 4.3 KB |
| v20-0001-libpq-Run-pgindent-after-a9e9a9f32b3.patch | application/octet-stream | 22.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-04-21 08:34:41 | Re: Make message strings in fe-connect.c consistent |
| Previous Message | Legs Mansion | 2023-04-21 08:16:10 | Re: A Question about InvokeObjectPostAlterHook |