Re: Make message strings in fe-connect.c consistent

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make message strings in fe-connect.c consistent
Date: 2023-04-21 08:34:41
Message-ID: 181BD61D-F0DB-4251-A703-693F2CE50B3C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 21 Apr 2023, at 07:02, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> On Thu, Apr 20, 2023 at 9:31 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>>>> libpq_append_conn_error(conn, "invalid require_auth method: \"%s\"",
>>>> method);
>>
>> Yup, this one did not get the memo.

I've pushed this, with the change to use the common "invalid %s value" format
that we use for all other libpq options. This makes this string make use of
already existing translations and makes error reporting consistent.

> That explains why I could not find any translation for this error message.

The feature is new in master so any translations for it are yet to be merged
from the translation repo.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2023-04-21 08:47:23 Re: Initial Schema Sync for Logical Replication
Previous Message Jelte Fennema 2023-04-21 08:20:35 Re: [EXTERNAL] Re: Add non-blocking version of PQcancel