Re: doc: modify the comment in function libpqrcv_check_conninfo()

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date: 2024-06-26 14:36:49
Message-ID: CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 26 Jun 2024 at 14:53, ikedarintarof
<ikedarintarof(at)oss(dot)nttdata(dot)com> wrote:
> The function 'libpqrcv_check_conninfo()' returns 'void', but the comment
> above says that the function returns true or false.
> I've attached a patch to modify the comment.

Agreed that the current comment is wrong, but the new comment should
mention the must_use_password argument. Because only if
must_use_password is true, will it throw an error.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-06-26 14:38:08 Re: Wrong security context for deferred triggers?
Previous Message Nathan Bossart 2024-06-26 14:23:18 Re: [PATCH] Add ACL (Access Control List) acronym