| From: | ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: doc: modify the comment in function libpqrcv_check_conninfo() |
| Date: | 2024-06-27 07:09:37 |
| Message-ID: | 9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for your comment!
I've added the must_use_password argument. A new patch is attached.
On 2024-06-26 23:36, Jelte Fennema-Nio wrote:
> On Wed, 26 Jun 2024 at 14:53, ikedarintarof
> <ikedarintarof(at)oss(dot)nttdata(dot)com> wrote:
>> The function 'libpqrcv_check_conninfo()' returns 'void', but the
>> comment
>> above says that the function returns true or false.
>> I've attached a patch to modify the comment.
>
> Agreed that the current comment is wrong, but the new comment should
> mention the must_use_password argument. Because only if
> must_use_password is true, will it throw an error.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch | text/x-diff | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simone Giusso | 2024-06-27 07:11:00 | ClientRead on ROLLABACK |
| Previous Message | Thomas Munro | 2024-06-27 06:32:52 | Re: CI, macports, darwin version problems |