From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
---|---|
To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Subject: | Re: Create syscaches for pg_extension |
Date: | 2024-09-05 16:50:59 |
Message-ID: | CAGECzQRJ7oEhzUWqPJRt4EUdZGvco15QKwvisOQpDQ0pz3wX+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 5 Sept 2024 at 15:41, Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> It seems that the get_extension_oid routine was not modified when the
> sys cache was introduced. What is the reason? It may be that this
> routine is redundant now, but if not, and we want to hold the API that
> extensions use, maybe we should rewrite it, too.
> See the attachment proposing changes.
It seems reasonable to make this function use the new syscache. I
didn't change any existing code in my original patch, because I wanted
to use the syscache APIs directly anyway and I didn't want to make the
patch bigger than strictly necessary. But I totally understand that
for many usages it's probably enough if the existing APIs are simply
faster (on repeated calls). The patch looks fine. But I think
get_extension_name and get_extension_schema should also be updated.
From | Date | Subject | |
---|---|---|---|
Next Message | Jacob Champion | 2024-09-05 17:08:23 | Re: Make query cancellation keys longer |
Previous Message | Tom Lane | 2024-09-05 16:49:42 | Re: Invalid "trailing junk" error message when non-English letters are used |