| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Create syscaches for pg_extension |
| Date: | 2024-09-05 13:41:19 |
| Message-ID: | 529295b2-6ba9-4dae-acd1-20a9c6fb8f9a@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/8/2024 03:49, Michael Paquier wrote:
> On Mon, Aug 19, 2024 at 03:21:30PM +0900, Michael Paquier wrote:
>> I won't hide that I've wanted that in the past..
>
> And I have bumped into a case where this has been helpful today, so
> applied. Thanks!
It had been my dream, too, for years. But the reason was the too-costly
call of the get_extension_oid routine (no less than pgbench 2-3% of
overhead when checked it in the planner hook).
It seems that the get_extension_oid routine was not modified when the
sys cache was introduced. What is the reason? It may be that this
routine is redundant now, but if not, and we want to hold the API that
extensions use, maybe we should rewrite it, too.
See the attachment proposing changes.
--
regards, Andrei Lepikhov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-EXTENSIONNAME-syscache-to-find-extension-oid.patch | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2024-09-05 13:43:24 | Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c) |
| Previous Message | Nitin Motiani | 2024-09-05 13:40:04 | Re: race condition in pg_class |