| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-02-28 04:37:22 |
| Message-ID: | CAGECzQQaBQmYfFK-PpP=NyqwgpH9Tf3G__5u_ggJyM+Sx0ik_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 28 Feb 2024 at 04:59, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Cool. I have applied 0004 and most of 0002. Attached is what
> remains, where I am wondering if it would be cleaner to do these bits
> together (did not look at the whole, yet).
Feel free to squash them if you prefer that. I think now that patch
0002 only includes encoding changes, I feel 50-50 about grouping them
together. I mainly kept them separate, because 0002 were simple search
+ replaces and 0003 required code changes. That's still the case, but
now I can also see the argument for grouping them together since that
would clean up all the encoding arrays in one single commit (without a
ton of other arrays also being modified).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-02-28 05:27:52 | Re: Injection points: some tools to wait and wake |
| Previous Message | Michael Paquier | 2024-02-28 04:26:46 | Re: Injection points: some tools to wait and wake |