| From: | Gus Spier <gus(dot)spier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | depesz(at)depesz(dot)com, Stephen Frost <sfrost(at)snowman(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Can we get rid of repeated queries from pg_dump? |
| Date: | 2021-08-29 11:35:21 |
| Message-ID: | CAG8xniczgQ9sK7oYObf_Y6Ppbbu53KEanRR+KWDJkZRkp3GsYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
You guys are brilliant!
Regards,
Gus
On Sat, Aug 28, 2021 at 6:26 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Here is a second patch, quite independent of the first one, that
> gets rid of some other repetitive queries. On the regression database,
> the number of queries needed to do "pg_dump -s regression" drops from
> 3260 to 2589, and on my machine it takes 1.8 sec instead of 2.1 sec.
>
> What's attacked here is a fairly silly decision in getPolicies()
> to query pg_policy once per table, when we could do so just once.
> It might have been okay if we skipped the per-table query for
> tables that lack policies, but it's not clear to me that we can
> know that without looking into pg_policy. In any case I doubt
> this is ever going to be less efficient than the original coding.
>
> regards, tom lane
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-08-29 13:13:15 | Re: Can we get rid of repeated queries from pg_dump? |
| Previous Message | Mladen Gogala | 2021-08-29 04:31:57 | Re: Insert statement doesn't complete |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-08-29 13:13:15 | Re: Can we get rid of repeated queries from pg_dump? |
| Previous Message | Himanshu Upadhyaya | 2021-08-29 08:06:56 | inconsistent behavior with "GENERATED BY DEFAULT AS IDENTITY" |