Re: Patch for setting preferences with user id

On Mon, Oct 8, 2018 at 5:36 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
> wrote:
>
>> On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Mon, Oct 8, 2018 at 4:18 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>> On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar <
>>>> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find here attached patch for following
>>>>>
>>>>> "modified the function test_utils/set_preference to accommodate
>>>>> user_id."
>>>>>
>>>>> It will help setting preferences in case user_id is other than
>>>>> 1(depending on the user which has been logged in).
>>>>>
>>>>
>>>> How would that ever happen? When running the tests, we initialise a new
>>>> settings database, so we're guaranteed that the user ID will be 1. If it
>>>> isn't, something is wrong.
>>>>
>>>> This is true for pgAdmin but not for PEM.
>>>
>> Currently - feature tests are running as the desktop (runtime) mode.
>> Tomorrow - if we want to enable the feature tests for the server mode,
>> then - this approach could be useful.
>>
>
> The tests can run in either mode.
>
No - currently it is running in the runtime mode only. :-)

-- Thanks, Ashesh

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>