From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, Usman Muzaffar <usman(dot)muzaffar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for setting preferences with user id |
Date: | 2018-10-08 12:06:06 |
Message-ID: | CA+OCxozr7tO2ERXmUrCqRZCH-w+EJ=Vwrsa2GSL7foqd8HvLFg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, Oct 8, 2018 at 1:00 PM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:
> On Mon, Oct 8, 2018 at 5:25 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Mon, Oct 8, 2018 at 4:18 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>> On Mon, Oct 8, 2018 at 9:08 AM Usman Muzaffar <
>>> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find here attached patch for following
>>>>
>>>> "modified the function test_utils/set_preference to accommodate
>>>> user_id."
>>>>
>>>> It will help setting preferences in case user_id is other than
>>>> 1(depending on the user which has been logged in).
>>>>
>>>
>>> How would that ever happen? When running the tests, we initialise a new
>>> settings database, so we're guaranteed that the user ID will be 1. If it
>>> isn't, something is wrong.
>>>
>>> This is true for pgAdmin but not for PEM.
>>
> Currently - feature tests are running as the desktop (runtime) mode.
> Tomorrow - if we want to enable the feature tests for the server mode,
> then - this approach could be useful.
>
The tests can run in either mode.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2018-10-08 12:08:01 | Re: Patch for setting preferences with user id |
Previous Message | Dave Page | 2018-10-08 12:04:52 | Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions |