PATCH: wxDatePickerCtrl also stores time along with date

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: PATCH: wxDatePickerCtrl also stores time along with date
Date: 2012-11-28 12:20:50
Message-ID: CAG7mmoz9tfrOmWp+2=yzwmKJFaCF7s9O+p45L3CAikTJCD3mnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi All,

We found an issue related to using wxDatePickerCtrl instead of
wxCalendarBox.
Actually - wxDatePickerCtrl does saves the time too, and that's why while
using it, it also add up time from the control in update SQL(s).

Because of that, the following scenario happens:
- Create a job 'a'
- Create a schedule 's1' for it.
Start-time: 28/11/12 15:00:00
End-time: 28/11/12 15:05:00
- Re-open the properties for the schedule 's1'.
It will show an update query.
Even - if you don't change the start/end date-time.

That's because the *calStart* (a wxDatePickerCtrl object) has the value
with time, and when *GetUpdateSql* gets called - the result for
'*calStart->GetValue()
+ timStart->GetValue()*' would be '29/11/12 06:00:00', which is not equal
to the actual value. Hence - generate wrong value.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*

Attachment Content-Type Size
FB22985.patch application/octet-stream 2.1 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2012-11-28 16:38:56 pgAdmin III commit: Date picker controls returns a full timestamp by
Previous Message Dave Page 2012-11-27 12:55:39 Re: Fixed documentation warnings