Re: PATCH: wxDatePickerCtrl also stores time along with date

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: wxDatePickerCtrl also stores time along with date
Date: 2012-11-28 16:40:08
Message-ID: CA+OCxoy7ZgLYkTOZFosBb7AKoP+PufNGnHXXPYg8QNSH6sW66Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Wed, Nov 28, 2012 at 12:20 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi All,
>
> We found an issue related to using wxDatePickerCtrl instead of
> wxCalendarBox.
> Actually - wxDatePickerCtrl does saves the time too, and that's why while
> using it, it also add up time from the control in update SQL(s).
>
> Because of that, the following scenario happens:
> - Create a job 'a'
> - Create a schedule 's1' for it.
> Start-time: 28/11/12 15:00:00
> End-time: 28/11/12 15:05:00
> - Re-open the properties for the schedule 's1'.
> It will show an update query.
> Even - if you don't change the start/end date-time.
>
> That's because the calStart (a wxDatePickerCtrl object) has the value with
> time, and when GetUpdateSql gets called - the result for
> 'calStart->GetValue() + timStart->GetValue()' would be '29/11/12 06:00:00',
> which is not equal to the actual value. Hence - generate wrong value.
>
> Please find the patch to resolve the issue.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
>
> http://www.linkedin.com/in/asheshvashi
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2012-11-28 17:31:18 Re: PATCH: wxDatePickerCtrl also stores time along with date
Previous Message Dave Page 2012-11-28 16:39:45 pgAdmin III commit: Date picker controls returns a full timestamp by