Re: How to enable PgAdmin Query Tool Favorites

Hi Vahdet,

The logic written to enable/disable menus were dependent on the current
focused control.
But - for some reason, wxWidgets was not able to get the current focused
control for certain events.
And, that was resulting into not disabling few menu items for Query Editor.

It was not just applied to "Add/Manage favourite", but - also some other
menu items in Edit menu.
i.e. Undo, Redo, Cut, Copy, Paste, etc.

I have made some changes in the current implementation to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Tue, Sep 22, 2015 at 11:59 AM, Vahdet Mert <vahdet(dot)mert(at)hotmail(dot)com>
wrote:

> Thanks J.F.
> I tried another desktop environment on Ubuntu: KDE (kubuntu) and the
> behaviour of the Query Tool Favorites is as expected. I can add new
> favorites and edit the existing ones using the GUI.
> As you said looks like the bug is related only to Unity. Which
> unfortunately is the default desktop environment for Ubuntu.
> regards,
> Vahdet
>
> ------------------------------
> Date: Fri, 18 Sep 2015 07:04:00 +0300
> From: jinfroster(at)mail(dot)ru
> To: vahdet(dot)mert(at)hotmail(dot)com
> CC: pgadmin-support(at)postgresql(dot)org
>
> Subject: Re: [pgadmin-support] How to enable PgAdmin Query Tool Favorites
>
> Hi!
>
>
> I've noticed this too but had no time to research.
> If I recall it correctly, there shows up some difference in events order
> when building the menu.
> May be, in buggy scenario, pgAdmin first checks the number of menu items
> (0) and decides to disable, later the menu is filled with items.
>
>
> If You are on Ubuntu, could you try with another desktop environment? (KDE
> or Gnome instead of default Unity).
> I remember that the bug shows up with Unity only.
>
>
>
>
>
>
> Thursday, September 17, 2015, 4:18:34 AM, you wrote:
>
>
> >
>
>
>
>
> Hi Colin,
> Thanks for the feedback. I have also pgAdmin III installed on my Windows 7
> workstation and I can observe there the exact behaviour that you are
> explaining:
> - add favorite remains greyed out until there is actually something in the
> query box to save
> - manage favs remains greyed out until there is something to manage
> But on my Ubuntu 14.04 laptop, the ‘Add favourite…’ and ‘Manage
> favourites…’ are greyed out all the time.
> I have text entered in the query box and the ‘Add favourite…’ is still
> grey.
> Regards,
> Vahdet
>
>
>
>
>
> ------------------------------
> Subject: Re: [pgadmin-support] How to enable PgAdmin Query Tool Favorites
> To: vahdet(dot)mert(at)hotmail(dot)com; pgadmin-support(at)postgresql(dot)org
> From: colbec(at)kingston(dot)net
> Date: Wed, 16 Sep 2015 05:12:33 -0400
>
>
> On 15/09/15 10:46 PM, Vahdet Mert wrote:
>
>
> Hi PGAdmin Support,
>
> On 2 Sep, I sent message to pgsql-bugs(at)postgresql(dot)org asking for help
> with PgAdmin Query Tool Favorites. I havent received any reply and I hope
> this group will be more helpful:
>
> Bug reference: 13605
> Logged by: Vahdet Mert
> Email address: vahdet(dot)mert(at)hotmail(dot)com
> PostgreSQL version: 9.3.9
> Operating system: ubuntu 14.04
> Description:
>
>
> I use pgAdmin extensively but cannot get the Query Tool favorites to work.
> The Add Favourite and Manage Favourite menu options are greyed out.
>
>
> I have a valid .pgadminfavorites xml file as I can edit the xml directly
> and
> see the resulting favorites queries under the Favorites menu. But I just
> cannot add new favorites or manage existing through the pgadmin interface.
>
>
> Running Ubuntu 14.04 and pgAdmin 1.18.1
>
>
> Thanks,
> Vahdet
>
>
> As feedback, works for me. I'm on openSUSE 13.2 latest pgadmin and I can
> save and retrieve queries. Note that the add favorite remains greyed out
> until there is actually something in the query box to save. As soon as a
> query is saved as a favourite, when you click the menu item the fav appears
> at the bottom of the list of options and a click on that brings it back.
> Manage favs remains greyed out until there is something to manage.
>
>
>
>
>
>
>
>
>
>
> --
> Best regards,
> J.F.
>