Re: [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi Khushboo,

On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Ashesh,
>
> I have changed the function name (from *render_deps* to *updateUIDeps*),
> which will be called on the dependent field change, as per your suggestion.
>
I've updated the patch.
Please try this.
I think - 'updateUIDeps' is not the write name.
A Cell can do anything, when dependent changed, hence - I renamed it with
'dependentChanged'.

Also, The user is not going to extend existing cell from the
DependendsCell, but - only going to use the functions.
Hence - I have created a separate class for it instead of extend it from
Backgrid.Cell.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> Please find attached patch for the same.
>
> Thanks,
> Khushboo
>
> On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Ashesh,
>>
>> Yes, agreed. This implementation limits us to use only String Cell.
>> So, I have modified the patch as you suggested.
>>
>> Please find the attachment for the same.
>>
>> Thanks,
>> Khushboo
>>
>> On Fri, Apr 1, 2016 at 2:59 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Khushboo,
>>>
>>> I am reluctant to use this code as it is.
>>> I would prefer you create just helper functions (i.e. initialize,
>>> remove) for the dependents in Backgrid.Cell, and then use them directly
>>> from the different cell itself.
>>> Because - this functionality limits us to us only with the string type.
>>>
>>> Anyway - we will be using the dependent functionality for very
>>> attributes.
>>>
>>>
>>> You can extend them directly in the Node's model (schema).
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>> On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch for the Backgrid *StringDepsCell.*
>>>>
>>>> The *StringDepsCell* displays HTML escaped strings and accepts anything typed in.
>>>> Also, Listen to the dependent fields.
>>>>
>>>>
>>>> Usage of the Backgrid Cell:
>>>>
>>>> If the Precision cell is dependent on the Datatype then:
>>>>
>>>> {
>>>> id: 'precision', label:'{{ _('Precision') }}', type: 'test'
>>>> cell: *Backgrid.Extension.StringDepsCell*, deps: ['datatype']
>>>>
>>>> }
>>>>
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>
>