From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Debugger]: Initial Patch |
Date: | 2016-04-06 08:07:08 |
Message-ID: | CA+OCxowidzrBrk1C-Z4JyF5Hqpk43TY8RQXtPwHd5TCgBdQQ8g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Apr 6, 2016 at 8:57 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> I got the root cause. Issue will reproduce when we applied Akshay's query
> tool patch.
> Issue was once the panel was initialized, HTML file was not getting loaded
> in to the panel due to the change in frame.js.
>
> Both query tool and debugger patch file contains the change in "frame.js"
> file. Once you applied the query tool patch and after that debugger then
> debugger patch should fail but i don't know why you do not get any error.
>
> Solution:-
>
> Open "frame.js" file and add the below line in "setTimeout" function which
> is required by debugger.
>
> pgBrowser.Events.trigger('pgadmin-browser:frame:urlloaded:'
> + that.name, frame, that.url, self);
>
> Do let us know if you still face the same issue.
Ahh, good catch - that got it :-)
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-04-06 09:08:37 | Re: [pgAdmin4][Patch]: Backgrid StringDepsCell |
Previous Message | Neel Patel | 2016-04-06 07:57:24 | Re: [pgAdmin4][Debugger]: Initial Patch |