Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

On Tue, May 31, 2016 at 1:56 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find updated patch with following changes:
> 1. the sizeHandler is not calculating the position without resizing
> 2. Apply sizeable columns to history grid in query tool.
> 3. Table column *Label and Type* should not be in single line. Currently
> *Backgrid* displays column and type in a single line considering it as
> text.
> we have to extend *headerCell* class and override its render method to
> fix this.
>
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> Please review.
>
> On Mon, May 30, 2016 at 11:36 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Fri, May 27, 2016 at 6:27 PM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi
>>>
>>> Please find updated patch with following changes:
>>>
>>> 1. Replaced the outdated code for *Backgrid Sizeable Columns plugin *with
>>> https://github.com/FortesSolutions/backgrid-sizeable-columns library
>>> because the updated code is available here.
>>> 2. I have figured out to calculate *offset* using the parameters of
>>> listener provided, so we need not to tweak the original library code.
>>>
>>> As per our conversation, the sizeHandler is not calculating the position
>> without resizing.
>> It should calculate the position even after rendering is completed.
>>
> Fixed.
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>>
>>> On Fri, May 27, 2016 at 5:00 PM, Surinder Kumar <
>>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Fri, May 27, 2016 at 4:43 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
>>>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>>> > Hi
>>>>> >
>>>>> > Added support for Columns resizable in query tool. It allows user to
>>>>> resize
>>>>> > the table columns as much as needed.
>>>>> >
>>>>> > We are using Backgrid Sizeable Columns plugin:
>>>>> > https://github.com/WRidder/backgrid-sizeable-columns
>>>>> >
>>>>> > with one change in library on line no 185:
>>>>> > moved the following trigger event out of if condition:
>>>>> >
>>>>> > if (newWidth != oldWidth) {
>>>>> >
>>>>> > }
>>>>> >
>>>>> >
>>>>> > and added one additional parameter offset.
>>>>> > //Trigger event
>>>>> >
>>>>> > view.columns.trigger("resize", columnModel, newWidth, oldWidth,
>>>>> offset);
>>>>> >
>>>>> >
>>>>> > We are listening to this trigger event in sqleditor.js file where we
>>>>> need
>>>>> > offset
>>>>> > to calculate new table width on every resize event.
>>>>>
>>>>> Please ensure any changes to third party libraries are submitted
>>>>> upstream.
>>>>>
>>>> yes, sure.
>>>>
>>>>>
>>>>> > hence, here is the patch attached.
>>>>>
>>>>> ENOATTACHMENT!
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>