Re: [PATCH] fix newly added server being lost when crashing

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] fix newly added server being lost when crashing
Date: 2014-01-06 11:29:07
Message-ID: CAG7mmoyfRG9v8VKqHhBXw=Wy-MzHEqRKHZ8QKPG6TGw3GBbf=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Kaarel,

I think - everything looks good except:
1. Please use TAB instead of 4 spaces
2. You don't require to define Flush function after inheriting the wxConfig
class publicly.
Or,
Define it only if you keep the wxConfig inherited protectively.

On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>wrote:

> Hi,
>
> Sending some 3 small fixes in separate emails for issues that me and my
> colleagues found really annoying. This is my first try at Pgadmin and I
> haven't done too much C++ though so in case something should be corrected
> let me know and I'd be happy to do that.
>
> Cheers,
> Kaarel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message J.F. Oster 2014-01-07 07:02:49 Re: PATCH: Improve status bar in Edit Data window
Previous Message Ashesh Vashi 2014-01-06 11:10:17 Re: [PATCH] fix newly added server being lost when crashing