Re: [PATCH] fix newly added server being lost when crashing

From: Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] fix newly added server being lost when crashing
Date: 2014-01-09 00:12:32
Message-ID: CA+gt1FfY8_YMFkD5=aooTLoZv2s4=S7sGVeDp_=zO7o2UKTjmg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ok, got it. Corrected version in attach now.

On Mon, Jan 6, 2014 at 12:29 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Kaarel,
>
> I think - everything looks good except:
> 1. Please use TAB instead of 4 spaces
> 2. You don't require to define Flush function after inheriting the
> wxConfig class publicly.
> Or,
> Define it only if you keep the wxConfig inherited protectively.
>
>
> On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>wrote:
>
>> Hi,
>>
>> Sending some 3 small fixes in separate emails for issues that me and my
>> colleagues found really annoying. This is my first try at Pgadmin and I
>> haven't done too much C++ though so in case something should be corrected
>> let me know and I'd be happy to do that.
>>
>> Cheers,
>> Kaarel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>

Attachment Content-Type Size
fix_server_loss_on_crashing_v2.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2014-01-09 04:41:17 Re: [PATCH] fix newly added server being lost when crashing
Previous Message Kaarel Moppel 2014-01-08 22:49:23 Re: [PATCH] Added a menu option to disable code folding