Re: Evaluate Sellect2 cell options properly [pgadmin4]

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Evaluate Sellect2 cell options properly [pgadmin4]
Date: 2016-06-03 09:51:16
Message-ID: CAG7mmoyGH+QeuzHOroYBjw79hvnnzFCrjvFB1dpYmQOZMJF-xQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Fri, Jun 3, 2016 at 3:17 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> There are two ways we can provide options for select2 cell either by
> extending select2 cell with "optionValues" array or by passing "options"
> (function or array) in column definition.
>
> Generally, if we are passing "optionValues" to select2 cell then we should
> not look for "options" in column definition but still we were looking for
> "options". This was causing javascript code to break if "options" were not
> passed in column definition.
>
> Error fixed:
>
> TypeError: this.column.get(...) is not a function
> (this.column.get('options'))(this) :
>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-06-03 09:53:22 pgAdmin 4 commit: Fixes #1298 - ACL for the SEQUENCE node were not pars
Previous Message Ashesh Vashi 2016-06-03 09:51:06 pgAdmin 4 commit: Proper evaluation of the optionsValues in the Backgri