| From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Evaluate Sellect2 cell options properly [pgadmin4] |
| Date: | 2016-06-03 09:47:15 |
| Message-ID: | CAFiP3vzJ4_NWygH8X_iPeoUEr99RkMy=t1iNFSH0juHngf9_1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
There are two ways we can provide options for select2 cell either by
extending select2 cell with "optionValues" array or by passing "options"
(function or array) in column definition.
Generally, if we are passing "optionValues" to select2 cell then we should
not look for "options" in column definition but still we were looking for
"options". This was causing javascript code to break if "options" were not
passed in column definition.
Error fixed:
TypeError: this.column.get(...) is not a function
(this.column.get('options'))(this) :
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| backgrid_select2_cell_options_issue.patch | text/x-patch | 777 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2016-06-03 09:51:06 | pgAdmin 4 commit: Proper evaluation of the optionsValues in the Backgri |
| Previous Message | Sandeep Thakkar | 2016-06-03 09:15:53 | Re: Patch for pgAdmin4 RPM package |