From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Oliver Switzer <oswitzer(at)pivotal(dot)io> |
Subject: | Re: [patch] Move to Alembic migration system |
Date: | 2017-04-21 05:21:08 |
Message-ID: | CAG7mmoxoP+iQuy_03q3A4SHskdwMjyU3AwR52SwYpZ_98mCRsg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Joao & Oliver,
On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hello Hackers,
>
> @Ashesh thanks for the feedback
>
> Here is the reviewed patch with the suggestions of Ashesh.
>
> Disclaimer: We added a new patch file with the changes
>
I have made some more changes to the patch.
- 'with app.app_context(..)' statement was not required in the
'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade
function.
- We also need to create other directories (i.e. sessions, storage,
directory containing the log-file) during the setup/running the application
(if not exists).
- Added proper check in the pgAdmin4.wsgi file (if configuration file
exists, or not)
Please review it.
-- Thanks, Ashesh
Attachment | Content-Type | Size |
---|---|---|
alembic_migration_system.patch | application/octet-stream | 47.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-04-21 05:35:58 | Re: [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool |
Previous Message | Khushboo Vashi | 2017-04-21 04:10:21 | Re: [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview |