Re: [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview
Date: 2017-04-21 04:10:21
Message-ID: CAFOhELfatPwxpYoO-2CRoKC0s9vre9MdxOKaS=dhOGyEdG5JHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.
I have tested this patch on Ubuntu (Chrome & Firefox) and Mac (Chrome).

Thanks,
Khushboo

On Tue, Apr 18, 2017 at 7:25 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Unfortunately I had to revert this, as I found it was preventing
> treeview nodes from being collapsed again. I'm running in Google
> Chrome on Mac, if that helps narrow down the problem.
>
> On Tue, Apr 18, 2017 at 2:01 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > Thanks, patch applied.
> >
> > On Fri, Apr 14, 2017 at 5:02 AM, Khushboo Vashi
> > <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> Hi,
> >>
> >> Please find the attached patch to fix the RM #2339: Horizontal
> scrolling in
> >> the treeview.
> >>
> >> I wanted to change the pgadmin.css file to fix this issue but the
> aciTree
> >> library is located at browser/static/vendor/, so I have included this
> change
> >> in the browser/static/css/browser.css file.
> >>
> >>
> >> Thanks,
> >> Khushboo
> >>
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_2339_ver1.patch text/x-patch 378 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-04-21 05:21:08 Re: [patch] Move to Alembic migration system
Previous Message Joao Pedro De Almeida Pereira 2017-04-20 22:09:41 Re: [patch] Move to Alembic migration system