From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: remove redundant local variables |
Date: | 2015-05-22 12:00:45 |
Message-ID: | CAG7mmoxmWF1oUxL=qUoDNHzHsxh1hr-So-sY78Q0dtBY+A3qag@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Sure.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Fri, May 22, 2015 at 5:18 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Ashesh, can you commit this please (if you agree it looks OK)? I don't
> have a working dev environment right now.
>
> On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Patch looks good to me.
> >
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> > On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> > <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> >>
> >> Hi Dave,
> >>
> >> Sure I will.
> >>
> >> Regards,
> >> Sanket Mehta
> >> Sr Software engineer
> >> Enterprisedb
> >>
> >> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>
> >>> Sanket, could you review this please?
> >>>
> >>> Thanks.
> >>>
> >>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <
> olshevskiy87(at)bk(dot)ru>
> >>> wrote:
> >>> > Hello.
> >>> > Please, take a look at this patch. There are several local variables,
> >>> > that
> >>> > obviously may be removed.
> >>> >
> >>> > --
> >>> > Dmitriy Olshevskiy
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> > Sent via pgadmin-hackers mailing list (
> pgadmin-hackers(at)postgresql(dot)org)
> >>> > To make changes to your subscription:
> >>> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2015-05-22 13:36:50 | pgAdmin III commit: Remove redundant local variables |
Previous Message | Dave Page | 2015-05-22 11:48:02 | Re: PATCH: remove redundant local variables |