From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: remove redundant local variables |
Date: | 2015-05-22 11:48:02 |
Message-ID: | CA+OCxox0JDaSAaQ-biWGpMYKWS+uzdCyNnLe=5gH9xYBZg5c6A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.
On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta
<sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2015-05-22 12:00:45 | Re: PATCH: remove redundant local variables |
Previous Message | Sanket Mehta | 2015-05-21 10:47:45 | Re: PATCH: remove redundant local variables |