From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> |
Cc: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: fix size check in dlgProperty |
Date: | 2015-07-08 05:17:40 |
Message-ID: | CAG7mmoxgZuYRUZv=T+_hk0nt6N7H3jvU10pBRpq6b-K33cp3Kw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, Jul 6, 2015 at 6:11 PM, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
wrote:
> Hi,
>
> Patch looks good to me.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Sat, Jul 4, 2015 at 4:07 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
> wrote:
>
>> hello again.
>> method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
>> expressions with l_size.GetWidth() in the conditional operator. I guess
>> the second
>> expression must by l_size.GetHeight() > 25.
>> I have attached the file with the correction. could you review it?
>> thank you.
>>
> Thanks Dmitriy Oleshevskiy for the patch.
Commited to the master branch.
> --
>> Dmitriy Olshevskiy
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2015-07-08 05:20:52 | pgAdmin III commit: Fixed a typo in dlgDefaultSecurityProperty::OnChang |
Previous Message | Ashesh Vashi | 2015-07-08 04:51:03 | Re: An error occurred"Column not found in pgSet: rolcateupdate" when connect to PostgreSQL 9.5 server |