Re: PATCH: fix size check in dlgProperty

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: fix size check in dlgProperty
Date: 2015-07-06 12:41:42
Message-ID: CA+yw=mMgbAGyOxROd+CrnRd5bB364kgf6Pjh0CgvG+xC7K-5oA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Patch looks good to me.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Sat, Jul 4, 2015 at 4:07 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
wrote:

> hello again.
> method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
> expressions with l_size.GetWidth() in the conditional operator. I guess
> the second
> expression must by l_size.GetHeight() > 25.
> I have attached the file with the correction. could you review it?
> thank you.
>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2015-07-07 05:05:49 Re: SSH error messages not shown
Previous Message Sanket Mehta 2015-07-06 10:41:36 Re: PATCH: fix typos