From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken |
Date: | 2016-06-07 08:16:29 |
Message-ID: | CAG7mmoxVEEXo0t1hx2reEaBkO4OkXkPZ7yJGDUYY6+5jbnpAWA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch for mentioned issue:
> *Issue*: Re-docking on the main tabset is broken
> *Explanation*:
> We were missing 'moveable' property. It should be set to false while
> creating new Browser panel. By default it is true for all registered panels.
> I think both browser and dashboard panels were moveable. that is why
> dockable tab couldn't determine where to re-dock.
>
That has fixed the original issue, but - now it does not allow me to dock
any of the panel beneath the 'Browser' panel.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
> I have also added support for moveable property in Panel class.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-07 08:24:01 | pgAdmin 4 commit: Fix styling of Alertify buttons |
Previous Message | Dave Page | 2016-06-07 08:06:38 | pgAdmin 4 commit: Fix typo per Susan. |