Re: [pgAdmin4]: Initial patch for Import table

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4]: Initial patch for Import table
Date: 2016-05-16 07:18:57
Message-ID: CAG7mmoxHOr9qdGD6XfmpcvZygbY0+LFrXbnM04mv489qg4D5tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Neel,

As discussed, I am sending you the updated path for based on your new patch
(sent personally, which included the background process integration).
Also, the COPY Statement expects the file to be present on the server OS,
hence - we should be using the '\copy' command of psql to do the job.
I have modified the patch accordingly, but - I did not get a chance to test
it properly, also - with some cosmetic changes.

Can you please review, and test it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Thu, May 5, 2016 at 4:43 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> Please find attached patch file which contains the table Import
> functionality.
> Attached patch file is depend on the following patch which is not
> committed yet.
>
> - File Manager patch
> - Table node patch
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Attachment Content-Type Size
import_latest_16May2016.patch application/octet-stream 22.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-05-16 07:52:53 pgAdmin 4 commit: Fixed issue while using decode() without checking typ
Previous Message Ashesh Vashi 2016-05-16 06:30:20 pgAdmin 4 commit: [Python 3 compatibility] Introduced a separate HTML s