From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4]: Initial patch for Import table |
Date: | 2016-05-17 07:11:28 |
Message-ID: | CACCA4P0VZiLs798vQ=cf00vBPUAm_Zt5krw7SN0oHJgiGAiWXg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
I have fixed some of the issues observed during testing and as per your
feedback added "Export" functionality as well.
I have tested it on both linux and windows and it is working.
Please find attached updated patch. Do review it and let me know for any
modifications.
Thanks,
Neel Patel
On Mon, May 16, 2016 at 12:48 PM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Neel,
>
> As discussed, I am sending you the updated path for based on your new
> patch (sent personally, which included the background process integration).
> Also, the COPY Statement expects the file to be present on the server OS,
> hence - we should be using the '\copy' command of psql to do the job.
> I have modified the patch accordingly, but - I did not get a chance to
> test it properly, also - with some cosmetic changes.
>
> Can you please review, and test it?
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Thu, May 5, 2016 at 4:43 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Hi,
>>
>> Please find attached patch file which contains the table Import
>> functionality.
>> Attached patch file is depend on the following patch which is not
>> committed yet.
>>
>> - File Manager patch
>> - Table node patch
>>
>> Do review it and let us know for comments.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
import_v3.patch | application/octet-stream | 25.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-05-17 07:24:07 | Re: PATCH: FTS configuration node |
Previous Message | Akshay Joshi | 2016-05-17 07:02:02 | pgAdmin 4 commit: Fixed issue change 'Auto Commit' option from preferen |