| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Levitt Olivier <olivier(dot)levitt(at)insee(dot)fr> |
| Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode |
| Date: | 2019-12-14 04:52:39 |
| Message-ID: | CAG7mmow_n3Gn0xz7FRFktg20jza8jJSJnMRKg7Xd6=NYBXmhsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
<http://www.linkedin.com/in/asheshvashi>
On Sat, Dec 14, 2019 at 3:53 AM Levitt Olivier <olivier(dot)levitt(at)insee(dot)fr>
wrote:
> Hi,
>
> When running the docker image in desktop mode
> (PGADMIN_CONFIG_SERVER_MODE=False), no user is created. That is expected
> behaviour.
> But then the code that imports the servers.json pre-configuration fails as
> it ties the import to the default user.
>
> I think line 40 of entrypoint.sh (
> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=pkg/docker/entrypoint.sh;h=47d14bf2d415777c64b221fb1fc75d61c5e3cecc;hb=HEAD)
> should not specify a user when running in dekstop mode.
> I tested it without --user parameter and it successfully imported the
> servers.json configuration.
>
> Should I submit a patch ? First time contributing to Pgadmin :)
>
Please do.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
> Regards,
> Olivier Levitt
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2019-12-14 05:05:28 | pgAdmin 4 commit: Fixed any typo - we were using the function |
| Previous Message | Levitt Olivier | 2019-12-13 14:52:46 | [Pgadmin] [Docker] servers.json import fails when running in desktop mode |