[Pgadmin] [Docker] servers.json import fails when running in desktop mode

From: Levitt Olivier <olivier(dot)levitt(at)insee(dot)fr>
To: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
Date: 2019-12-13 14:52:46
Message-ID: 74F4D0C2ACDFA04BA40C6475ADAE217529FA3FDA@pdexchbalwst03.ad.insee.intra
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

When running the docker image in desktop mode (PGADMIN_CONFIG_SERVER_MODE=False), no user is created. That is expected behaviour.
But then the code that imports the servers.json pre-configuration fails as it ties the import to the default user.

I think line 40 of entrypoint.sh (https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=pkg/docker/entrypoint.sh;h=47d14bf2d415777c64b221fb1fc75d61c5e3cecc;hb=HEAD) should not specify a user when running in dekstop mode.
I tested it without --user parameter and it successfully imported the servers.json configuration.

Should I submit a patch ? First time contributing to Pgadmin :)

Regards,
Olivier Levitt

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2019-12-14 04:52:39 Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
Previous Message Aditya Toshniwal 2019-12-13 06:39:09 [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements