| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Subject: | Re: Docker build simplification |
| Date: | 2019-09-11 10:59:11 |
| Message-ID: | CAG7mmowKzjw6SF0cEreiTzJg=R5E-Oyc5zsO2fp_F45XyHBH1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Tue, Sep 10, 2019 at 11:21 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> The attached patch simplifies the Docker container build so that it can be
> done entirely using "docker build" in the root of a source tree. It also
> enables building the container from a tarball, not just a git checkout.
> This does mean that container builds may now also include any garbage in
> the source tree from which they're built, but conversely offers the benefit
> of making it easy to build a container with code changes in it without
> having to commit first.
>
> Akshay, can you look it over to make sure I haven't done anything
> obviously stupid? Feedback from others is also welcome of course.
>
Dave,
Is there any reason - we're not using the requirements.txt from the docker
file, and installing the packages separately.
-- Thanks, Ashesh
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-09-11 11:14:17 | Re: Docker build simplification |
| Previous Message | Akshay Joshi | 2019-09-11 10:30:52 | pgAdmin 4 commit: 1) Add Reverse Engineered and Modified SQL tests for |