From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal - function string_to_table |
Date: | 2020-09-03 03:01:25 |
Message-ID: | CAFj8pRDFeFB+T+0iAaYmzLXvCrXYeSPjgQ69kDAk2XeiUMLrDA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
čt 3. 9. 2020 v 0:30 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > [ string_to_table-20200825.patch ]
>
> I reviewed this, whacked it around a little, and pushed it.
>
> Possibly the most controversial thing I did was to move the existing
> documentation entry for string_to_array() into the string-functions
> table. I did not like it one bit that the patch was documenting
> string_to_table() far away from string_to_array(), and on reflection
> I concluded that you'd picked the right place and the issue here is
> that string_to_array() was in the wrong place.
>
> Also, I pared the proposed regression tests a great deal, ending up
> with something that matches the existing tests for string_to_array().
> The proposed tests seemed mighty duplicative, and they even contained
> syntax errors, so I didn't believe that they were carefully considered.
>
Thank you
Pavel
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2020-09-03 04:57:47 | Re: Fix for configure error in 9.5/9.6 on macOS 11.0 Big Sur |
Previous Message | Michael Paquier | 2020-09-03 02:14:38 | Re: Refactor ReindexStmt and its "concurrent" boolean |